Re: [PATCH 1/6] mc13xxx: Define maximum SPI clock frequency global to driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 20, 2012 at 12:05:21PM +0400, Alexander Shiyan wrote:
> > 
> >  The values indeed look quite arbitrary, but it may be that a hardware
> >  design does not support such high frequencies. Maybe better
> > 
> >  if (!mc_dev->spi->max_speed_hz)
> >  mc_dev->spi->max_speed_hz = 20000000
> > 
> >  ?
> On my opinion, tests for supported speed, is work for SPI-driver, not for device driver.
> Is not it?

So you mean that the i.MX spi drivers platform data should have a
maximum speed field instead of the client drivers? Sounds good.
In this case we can apply the patch.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox


[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux