While a set bit enables the pullup (if exists) it disables the bitkeeper (if exists). Both features are using the same register bit and only one of this feature is present on a per pin base. Signed-off-by: Juergen Beisert <jbe@xxxxxxxxxxxxxx> diff --git a/arch/arm/mach-mxs/iomux-imx.c b/arch/arm/mach-mxs/iomux-imx.c index 9203588..784c506 100644 --- a/arch/arm/mach-mxs/iomux-imx.c +++ b/arch/arm/mach-mxs/iomux-imx.c @@ -125,7 +125,7 @@ void imx_gpio_mode(uint32_t m) if (BK_PRESENT(m)) { reg_offset = calc_pullup_reg(gpio_pin); writel(0x1 << (gpio_pin % 32), IMX_IOMUXC_BASE + reg_offset + - (GET_BITKEEPER(m) == 1 ? BIT_SET : BIT_CLR)); + (GET_BITKEEPER(m) == 1 ? BIT_CLR : BIT_SET)); } if (GET_FUNC(m) == IS_GPIO) { -- Pengutronix e.K. | Juergen Beisert | Linux Solutions for Science and Industry | http://www.pengutronix.de/ | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox