On 2 June 2012 06:52, Jean-Christophe PLAGNIOL-VILLARD
<plagnioj@xxxxxxxxxxxx> wrote:
> On 13:23 Fri 01 Jun , Antony Pavlov wrote:
>> In the commit 40492a0c1305835c996e15eb1cce2406473ae76d
>> (MIPS: add common header file for DEBUG_LL via NS16550)
>> introduced common DEBUG_LL via NS16550 for MIPS
>> (see file arch/mips/include/debug_ll_ns16550.h).
>>
>> In the commit 1cbe2b2c00de0efca503a983d0d008833f186f33
>> (MIPS: XBurst: add Ritmix RZX-50 board support)
>> the file debug_ll_ns16550.h used in
>> the file arch/mips/mach-xburst/include/mach/debug_ll.h.
>>
>> Usage looks like this:
>>
>> ------------------------------------------------
>> +#ifdef CONFIG_BOARD_RZX50
>> +#include <mach/debug_ll_jz4755.h>
>> +#endif
>> +
>> +#include <debug_ll_ns16550.h>
>> ------------------------------------------------
>>
>> So after adding another board (e.g. A320) we will have something like this:
>>
>> ------------------------------------------------
>> #ifdef CONFIG_BOARD_RZX50
>> #include <mach/debug_ll_jz4755.h>
>> #endif
>>
> I'll include it via config.h or at least have a common hearder name and just
> have a single config to enable it and then enable it at board config level
This patch makes the chain:
include/debug_ll.h (controlled by CONFIG_DEBUG_LL)
\
`arch/mips/mach-xburst/include/mach/debug_ll.h (included if
CONFIG_DEBUG_LL=y)
\
`arch/mips/boards/rzx50/include/board/debug_ll.h (actual setup)
That is wrong?
--
Best regards,
Antony Pavlov
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
