On 31 May 2012 22:52, Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote: > On Thu, May 24, 2012 at 05:50:20PM +0400, Antony Pavlov wrote: >> In the commit 40492a0c1305835c996e15eb1cce2406473ae76d >> (MIPS: add common header file for DEBUG_LL via NS16550) >> introduced common DEBUG_LL via NS16550 for MIPS >> (see file arch/mips/include/debug_ll_ns16550.h). >> >> In the commit 1cbe2b2c00de0efca503a983d0d008833f186f33 >> (MIPS: XBurst: add Ritmix RZX-50 board support) >> the file debug_ll_ns16550.h used in >> the file arch/mips/mach-xburst/include/mach/debug_ll.h. >> >> Usage looks like this: >> >> ------------------------------------------------ >> +#ifdef CONFIG_BOARD_RZX50 >> +#include <mach/debug_ll_jz4755.h> >> +#endif >> + >> +#include <debug_ll_ns16550.h> >> ------------------------------------------------ >> >> So after adding another board (e.g. A320) we will have something like this: >> >> ------------------------------------------------ >> #ifdef CONFIG_BOARD_RZX50 >> #include <mach/debug_ll_jz4755.h> >> #endif >> >> +#ifdef CONFIG_BOARD_A320 >> +#include <mach/debug_ll_jz4740.h> >> +#endif >> >> #include <debug_ll_ns16550.h> >> ------------------------------------------------ >> >> This approach has disadvantage: >> * the files mach/debug_ll_jz4740.h and mach/debug_ll_jz4755.h >> (they go to arch/mips/arch-xburst) are __BOARD-SPECIFIC__ >> (not SOC- or mach-specific!); The file mach-xburst/include/mach/debug_ll.h >> is outside board directory, but it contain some board related information. >> >> This commit introduce more suitable solution. > > Looks good. OK to apply? No, please. There is a trivial mistype in this patch. I'll resend the fixed patch in a short time. -- Best regards, Antony Pavlov _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
