Re: [PATCH 2/2] block: do not BUG() on failed block_get

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

On Wed, May 30, 2012 at 7:31 AM, Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote:
It does not necessarily means a bug when block_get fails here,
this can also be a failure on the underlying device.

Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
---
 common/block.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/block.c b/common/block.c
index 437dc95..5983171 100644
--- a/common/block.c
+++ b/common/block.c
@@ -245,7 +245,7 @@ static int block_put(struct block_device *blk, const void *buf, int block)

       data = "" block);
       if (IS_ERR(data))
-               BUG();
+               return PTR_ERR(data);

       memcpy(data, buf, 1 << blk->blockbits);

--
1.7.10


Tested-by: Roberto Nibali <rnibali@xxxxxxxxx>
Acked-by: Roberto Nibali <rnibali@xxxxxxxxx>

 

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox

[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux