On Thu, May 24, 2012 at 07:27:44PM +0600, Alexey Galakhov wrote:
> Signed-off-by: Alexey Galakhov <agalakhov@xxxxxxxxx>
> ---
> arch/arm/mach-samsung/Makefile | 2 +-
> arch/arm/mach-samsung/include/mach/s3c-generic.h | 6 +
> arch/arm/mach-samsung/include/mach/s5pcxx-iomap.h | 3 +
> arch/arm/mach-samsung/mem-s5pcxx.c | 319 +++++++++++++++++++++
> 4 files changed, 329 insertions(+), 1 deletion(-)
> create mode 100644 arch/arm/mach-samsung/mem-s5pcxx.c
>
> +
> +static void __bare_init s5p_dram_init_seq_lpddr(phys_addr_t base, unsigned chip)
> +{
> + const uint32_t emr = 0x400; /* DQS disable */
> + const uint32_t mr = (((S5P_DRAM_WR) - 1) << 9)
> + | ((S5P_DRAM_CAS) << 4)
> + | (S5P_DRAM_BURST);
> + /* FIXME this sequence is untested */
Maybe add these comments to the exported functions rather than in the
helpers? It would be more prominent and people would see it more easily.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
