On Tue, May 15, 2012 at 07:20:35PM +0600, Alexey Galakhov wrote: > Signed-off-by: Alexey Galakhov <agalakhov@xxxxxxxxx> > --- > diff --git a/arch/arm/boards/a9m2410/a9m2410.c b/arch/arm/boards/a9m2410/a9m2410.c > index eaafdbd..31ed772 100644 > --- a/arch/arm/boards/a9m2410/a9m2410.c > +++ b/arch/arm/boards/a9m2410/a9m2410.c > @@ -51,7 +51,7 @@ static int a9m2410_mem_init(void) > * Note: On this card the second SDRAM page is not used > */ > s3c24xx_disable_second_sdram_bank(); > - size = s3c24xx_get_memory_size(); > + size = s3c_get_memory_size(); Still you convert two different functions to a common name. Once again: Please keep s3c24xx_get_memory_size and add a s5p_get_memory_size function for the s5p SoC. It turned out to be useful when functions (or defines) have a spcific SoC name in them. This way you always know in which context a function is valid. Also it makes it possible to compile in all (in this case memory setup) functions in a single binary. I know that we do not follow this rule very strictly in barebox, but I won't accept patches that change places that do it right already. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
