Hi Sascha, 2011/7/26 Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>: > Hi Franck, > > On Mon, Jul 25, 2011 at 09:50:18PM +0200, franck.jullien@xxxxxxxxx wrote: >> From: Franck Jullien <franck.jullien@xxxxxxxxx> >> >> Signed-off-by: Franck Jullien <franck.jullien@xxxxxxxxx> >> --- >> drivers/net/altera_tse.c | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/altera_tse.c b/drivers/net/altera_tse.c >> index ac8cd2d..4298739 100644 >> --- a/drivers/net/altera_tse.c >> +++ b/drivers/net/altera_tse.c >> @@ -510,7 +510,7 @@ static int tse_probe(struct device_d *dev) >> dev->type_data = edev; >> edev->priv = (struct altera_tse_priv *)(edev + 1); >> >> - edev->iobase = dev->map_base; >> + edev->iobase = (int)dev_request_mem_region(dev, 0); > > Damned. I wasn't aware that struct eth_device has an int iobase. > Can you please move your iobase to edev->priv (as a void __iomem *)? > No problem. I'll also use resources for sgdma_tx and sgdma_rx. I'll resend the patch tonight. > Then we can remove this otherwise unused field from eth_device. > > Sascha > > -- > Pengutronix e.K. | | > Industrial Linux Solutions | http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox