On 13:00 Tue 19 Jul , Sascha Hauer wrote:
> On Tue, Jul 19, 2011 at 12:13:47PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 10:39 Tue 19 Jul , Sascha Hauer wrote:
> > > Add a helper function for boards to register their memory
> > > devices. This makes the board code smaller and also helps
> > > getting rid of map_base.
> > >
> > > Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> > > ---
> > > commands/mem.c | 25 +++++++++++++++++++++++++
> > > include/driver.h | 6 ++++++
> > > 2 files changed, 31 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/commands/mem.c b/commands/mem.c
> > > index 8df5f0a..745eec4 100644
> > > --- a/commands/mem.c
> > > +++ b/commands/mem.c
> > > @@ -587,6 +587,31 @@ static struct file_operations memops = {
> > > .lseek = dev_lseek_default,
> > > };
> > >
> > > +struct device_d *add_mem_device(const char *name, unsigned long start, size_t size,
> > > + unsigned int flags)
> > > +{
> > > + struct device_d *dev;
> > > + struct memory_platform_data *pdata;
> > > +
> > > + dev = xzalloc(sizeof(*dev));
> > > + strcpy(dev->name, "mem");
> > > + dev->id = -1;
> > > + dev->resource = xzalloc(sizeof(struct resource));
> > > + dev->num_resources = 1;
> > > + dev->resource[0].start = start;
> > > + dev->resource[0].size = size;
> > > + dev->resource[0].flags = IORESOURCE_MEM;
> > > + pdata = xzalloc(sizeof(*pdata));
> > > + dev->platform_data = pdata;
> > > +
> > > + pdata->flags = flags;
> > > + pdata->name = xstrdup(name);
> > can we drop the name here and use the resource name instead
>
> I think so, yes.
>
> >
> > I think we can drop the platfrom_data too
>
> This is still needed for the rw/ro flag (though it seems this is not
> handled)
I agree so we need to pass via flags also and maybe extend it
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
