Mostly ACK, but ...
Sascha Hauer wrote:
> These are mostly useful for developers, so turn them off by default.
>
> Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> ---
> drivers/mci/mci-core.c | 26 +++++++++++++-------------
> 1 files changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c
> index a51c44b..c4c5c2f 100644
> --- a/drivers/mci/mci-core.c
> +++ b/drivers/mci/mci-core.c
>
> [...]
>
> @@ -1182,7 +1182,7 @@ static int mci_card_probe(struct device_d *mci_dev)
> /* start with a host interface reset */
> rc = (host->init)(host, mci_dev);
> if (rc) {
> - pr_err("Cannot reset the SD/MMC interface\n");
> + pr_debug("Cannot reset the SD/MMC interface\n");
> return rc;
> }
This is not only useful for the developer. Also for the regular user when
something is broken at runtime.
> @@ -1192,7 +1192,7 @@ static int mci_card_probe(struct device_d *mci_dev)
> /* reset the card */
> rc = mci_go_idle(mci_dev);
> if (rc) {
> - pr_warning("Cannot reset the SD/MMC card\n");
> + pr_debug("Cannot reset the SD/MMC card\n");
> goto on_error;
> }
Also useful for the regular user, that tries his shiny new and fresh SD card
and something went wrong at runtime.
>
> [...]
>
jbe
--
Pengutronix e.K. | Juergen Beisert |
Linux Solutions for Science and Industry | Phone: +49-8766-939 228 |
Vertretung Sued/Muenchen, Germany | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
