Hi Eric, On Mon, Nov 01, 2010 at 02:29:21PM +0100, Eric Bénard wrote: > Hi Jürgen, > > Le 01/11/2010 14:19, Sascha Hauer a écrit : >> General remarks about this series: >> >> - Please do not add code with '#if 0' and activate it later. This shows >> the series has the wrong order. >> - Please refrain from basing your internal functions around 'struct >> device_d'. By doing so we completey lose type safety and at least in >> case of the mci framework where three different devices are involved >> this leads to unreadable and error prone code. The framebuffer >> code should be based around struct fb_info. >> - Please keep the line lengths within sensible limits. >> - Get rid of CONFIG_VIDEO_DELAY_INIT and make the mode runtime >> changeable. All this requires is a >> host->fb_disable(info); host->fb_mode(info, newmode); host->fb_enable(mode); >> > and pcr in imxfb_mode which describes polarity of signals and thus can > change from a screen to another. This is handled in a later patch. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
