Sascha Hauer wrote:
> On Fri, Oct 22, 2010 at 06:53:23PM +0200, Juergen Beisert wrote:
> > As there is currently no user of this driver (but coming soon) it is for
> > reference only.
> >
> > [...]
> > + default:
> > + printf("Unknown pixel packaging: %u\n", GET_BYTE_PACKAGING(readl(hw_dev->map_base + HW_LCDIF_CTRL1)));
>
> Care to spend a line break?
I like long lines... ;-)
Yes, I will add a line break the next time.
> > [...]
> > +static int stmfb_probe(struct device_d *hw_dev)
> > +{
> > + struct imx_fb_videomode *pdata = hw_dev->platform_data;
> > + struct device_d *fb_dev;
> > +
> > + if (pdata == NULL) {
> > + pr_debug("STMFB: No platformdata. Giving up\n");
>
> We also have dev_dbg and friends for this.
Yes.
jbe
--
Pengutronix e.K. | Juergen Beisert |
Linux Solutions for Science and Industry | Phone: +49-8766-939 228 |
Vertretung Sued/Muenchen, Germany | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
