On Fri, Sep 24, 2010 at 13:44, Jean-Christophe PLAGNIOL-VILLARD wrote:
> +if [ ! "${LOGDIR}" ] ; then
> + Â Â Â LOGDIR="LOG"
> +fi
simpler syntax:
: ${LOGDIR:=LOG}
> +if [ ! "${BUILDDIR}" ] ; then
> + Â Â Â BUILDIR="makeall_buildir"
> Âfi
: ${BUILDDIR:=makeall_builddir}
i think your patch misses a "d" here at least ...
> +CROSS_COMPILE_arm=/opt/arm-2007q3/bin/arm-none-linux-gnueabi-
> +CROSS_COMPILE_m68k=m68k-uclinux-
> +CROSS_COMPILE_blackfin=/opt/uClinux/bfin-linux-uclibc/bin/bfin-linux-uclibc-
> +CROSS_COMPILE_ppc=/opt/powerpc/bin/powerpc-unknown-linux-gnu-
> +CROSS_COMPILE_sandbox=/usr/bin/
> +CROSS_COMPILE_x86=/usr/bin/
i dont think hardcoding paths is a good idea, and bfin-linux-uclibc-
might not work. so bfin-uclinux- might be better.
-mike
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
