Hi J, The subject should be '...fail if we can *not* get the clock'. On Sun, Sep 12, 2010 at 01:27:39PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@xxxxxxxxxxxx> > --- > drivers/serial/amba-pl011.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/drivers/serial/amba-pl011.c b/drivers/serial/amba-pl011.c > index 07508d0..8ddba2e 100644 > --- a/drivers/serial/amba-pl011.c > +++ b/drivers/serial/amba-pl011.c > @@ -34,6 +34,7 @@ > #include <asm/io.h> > #include <linux/amba/serial.h> > #include <linux/clk.h> > +#include <linux/err.h> > > /* > * We wrap our port structure around the generic console_device. > @@ -160,6 +161,9 @@ static int pl011_probe(struct device_d *dev) > > uart->clk = clk_get(dev, NULL); > > + if (PTR_ERR(uart->clk) < 0) We have the IS_ERR macro for testing. PTR_ERR is wrong here because it only casts the pointer to long, so the condition above is true for every pointer > 0x80000000. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
