Re: [PATCH 4/6] imx35pdk: correct mode for display contrast pin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Marc Reilly wrote:

Please don't forget to add you'r S-o-b.

Cheers, Marc

> ---
>  board/freescale-mx35-3-stack/3stack.c |    7 +++----
>  1 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/board/freescale-mx35-3-stack/3stack.c b/board/freescale-mx35-3-stack/3stack.c
> index fcb87cf..d09de65 100644
> --- a/board/freescale-mx35-3-stack/3stack.c
> +++ b/board/freescale-mx35-3-stack/3stack.c
> @@ -201,10 +201,8 @@ device_initcall(f3s_devices_init);
>  
>  static int f3s_enable_display(void)
>  {
> -	gpio_direction_output(1, 1);
> -
>  	/* Enable power to the LCD. (bit 6 hi.) */
> -	mc9sdz60_set_bits( mc9sdz60_get(), MC9SDZ60_REG_GPIO_1, 0x40, 0x40);
> +	mc9sdz60_set_bits(mc9sdz60_get(), MC9SDZ60_REG_GPIO_1, 0x40, 0x40);
>  
>  	return 0;
>  }
> @@ -270,10 +268,11 @@ static struct pad_desc f3s_pads[] = {
>  	MX35_PAD_D3_HSYNC__IPU_DISPB_D3_HSYNC,
>  	MX35_PAD_D3_FPSHIFT__IPU_DISPB_D3_CLK,
>  	MX35_PAD_D3_DRDY__IPU_DISPB_D3_DRDY,
> -	MX35_PAD_CONTRAST__GPIO1_1,
> +	MX35_PAD_CONTRAST__IPU_DISPB_CONTR,
>  	MX35_PAD_D3_VSYNC__IPU_DISPB_D3_VSYNC,
>  	MX35_PAD_D3_REV__IPU_DISPB_D3_REV,
>  	MX35_PAD_D3_CLS__IPU_DISPB_D3_CLS,
> +	

IMHO no need for this line, please remove.

>  };
>  
>  static int f3s_console_init(void)


-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox

[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux