Hi Marc, On Mon, Apr 12, 2010 at 02:22:45PM +1000, Marc Reilly wrote: > Hi, > > These patches enable power to the mx35 3stack LCD. Thanks for working on this. All applied. > > (First time -so please pardon any transgressions of patching etiquette.) As you are using git please consider sending patches with git send-email next time. It sends patches inline and one mail per patch. This helps a lot in reviewing and applying the patches. > > It'd be nice for someone to double check what I've done in > f3s_pmic_init_all(). I'm not sure what the original author was intending to > turn on/off and whether these patches break that. I've preserved the bit > banging of the physical lines themselves under the assumption that whatever it > was doing before was the correct/intended behavior. Looks good, though I haven't tested it yet. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
