Dave Jones <davej@xxxxxxxxxxxxxxxxx> writes: > On Tue, Feb 07, 2017 at 09:05:45PM +1100, Michael Ellerman wrote: > > Tommi Rantala <tt.rantala@xxxxxxxxx> writes: > > > diff --git a/Makefile b/Makefile > > > index b93fc3a..16fafe8 100644 > > > --- a/Makefile > > > +++ b/Makefile > > > @@ -2,7 +2,7 @@ VERSION="1.8pre" > > > > > > INSTALL_PREFIX ?= $(DESTDIR) > > > INSTALL_PREFIX ?= $(HOME) > > > -NR_CPUS := $(shell grep ^processor /proc/cpuinfo | /usr/bin/wc -l) > > > +NR_CPUS := $(shell grep -c ^processor /proc/cpuinfo) > > > > Or you could just use nproc(1) ? > > Is that in ancient coreutils from crusty old enterprise distros ? > Judging by user reports, I think we need to support back as far as > RHEL6 for now. Good point. It's there on my RHEL 6.8 box, which is the oldest I have lying around, and looks like it first existed in ~2009. But may not be worth the potential breakage. > > It's in coreutils, but maybe that's not sufficiently portable? > > Portability to non-Linux OS's hasn't been a concern so far. > I had 1-2 people email me about BSD support but the patches they've sent > have been about 1% of the work actually necessary so I've just rejected > them. > > It's way easier to just extend iknowthis (or possibly syzkaller) > than to retrofit it into Trinity at this point. > > I admit to having a morbid curiousity to know just how well the various > BSD's would hold up under a targetted fuzzing run, but the likelyhood of > me finding time to work on it, or even support it, is practically nil. I know the feeling, there's another operating system it would be fun to run on too, but likewise I will never get the time :) cheers -- To unsubscribe from this list: send the line "unsubscribe trinity" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
