On Wed, Oct 16, 2013 at 01:43:22PM +0300, Mikko Rapeli wrote:
> It can be a configuration or ortherwise important warning/error.
>
> Signed-off-by: Mikko Rapeli <mikko.rapeli@xxxxxx>
I don't like this one, because in most cases, these aren't important.
On some machines, we even expect some of them to fail. Example, on a Fedora 19
system we run this test, which we expect to fail..
[*] Checking if glibc headers provide termios2.. [NO]
/home/davej/tmp/tmp.U0xuPLOakW.c: In function ‘main’:
/home/davej/tmp/tmp.U0xuPLOakW.c:7:18: error: storage size of ‘test’ isn’t known
struct termios2 test;
^
Printing out an 'error' when there's nothing actually wrong seems alarmist.
Especially when we do the right thing, and include the right header afterwards.
Dave
--
To unsubscribe from this list: send the line "unsubscribe trinity" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
