[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 07, 2013 at 06:26:18PM -0700, Ildar Muslukhov wrote:
 > 
 > This patch removes almost all printf and wires them into output functions, 
 > defined in log.c. As a result this patch also fixes bugs with "stack smash 
 > detected" and emission of ANSI control symbols even if -m (monochrome 
 > mode) is specified.
 > 
 > I gave it a run for couple of hours with differnt parameters, seems to be 
 > working, but worth additional testing, since it touches many files.
 > 
 > Signed-off-by: Ildar Muslukhov <ildarm@xxxxxxxxxx>
 
Just like last time, this needs chopping into lots of smaller patches.
It's unreviewable when you make many changes in one diff like this.

Your workflow should be using git commit often, for the smallest possible change,
and then when you're done, post a series of patches generated with 'git format-diff origin..'
 
	Dave

--
To unsubscribe from this list: send the line "unsubscribe trinity" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SCSI]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux