Yes, it gave me problems in the beginning, but after removing static from the function and taking care of ebp it worked. Will test it on my machine in a moment. BTW which kernel version are you running against? On Wed, Oct 2, 2013 at 8:12 AM, Dave Jones <davej@xxxxxxxxxx> wrote: > On Thu, Sep 19, 2013 at 02:24:24PM -0700, Ildar Muslukhov wrote: > > > > This patch fixes missing 6th param for 32bit syscalls in i386 and x86_64 > > archs. > > > > Note: I have to remove static from syscall32, because gcc messes up with > > inline asm becuase of that. > > Something isn't quite right with this. > I was looking at a log file and noticed that in a lot of cases, we end up > doing a 32bit syscall, and then the child respawns. I suspected it > was segfaulting, and running with -D confirms it. > > A whole bunch of core dumps appears, looking like this.. > > Core was generated by `../trinity -q -D'. > Program terminated with signal 11, Segmentation fault. > #0 0x0000000000403aa5 in syscall32 (a6=<optimized out>, a5=5, a4=9709, a3=29, a2=4, a1=<optimized out>, call=279, num_args=5) at syscall.c:76 > 76 __syscall_return(long,__res); > > This is running on x86-64, I haven't tested actually running on a 32-bit machine, > but I suspect it's a problem there too. > > Dave > -- To unsubscribe from this list: send the line "unsubscribe trinity" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
