On Wed, Jul 03, 2013 at 05:07:38PM -0400, Vince Weaver wrote:
>
> The following patch should properly handle decimal values in
> /sys/bus/event_source/devices/cpu/events/
> files.
applied and pushed. thanks.
> Feel free to run lindent on the whole perf_event_open.c sometime.
maybe next week ;)
btw, here's something curious that llvm finds when you build trinity with clang.
I'm not sure if this is a real problem, or a bug in the compiler, but you
might want to take a look anyway:
syscalls/perf_event_open.c:66:19: warning: Assigned value is garbage or undefined
format_string[i]=string[i];
^~~~~~~~~~
syscalls/perf_event_open.c:159:12: warning: Assigned value is garbage or undefined
field[i]=value[ptr];
^~~~~~~~~~~
In case you're not setup for llvm, I've put the decision trees it generated at
http://codemonkey.org.uk/junk/1.html
http://codemonkey.org.uk/junk/2.html
It may be that some of those combinations it took will never happen, but
I'd like to know for sure. (and if possible somehow silence the warnings
as long as it doesn't ugly stuff up too much)
Dave
--
To unsubscribe from this list: send the line "unsubscribe trinity" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
