2013/5/24 Nico Golde <nico@xxxxxxxxx>: > Hi, > * Tommi Rantala <tt.rantala@xxxxxxxxx> [2013-05-23 20:58]: >> 2013/5/22 Nico Golde <nico@xxxxxxxxx>: >> > I changed the code the following way: >> > @@ -21,7 +22,8 @@ static size_t bldevs, chrdevs, miscdevs; >> > static void parse_proc_devices(void) >> > { >> > FILE *fp; >> > - char *name, *line = NULL; >> > + char *line = NULL; >> > + char name[32]; >> >> It would be IMO preferable to not hardcode the max length. > > I agree, this is actually left over from quickly changing this. > Are you aware of a proper maximum defined in the kernel headers or do we want to > allocate this completely dynamically? dynamic please! > Cheers > Nico > -- > To unsubscribe from this list: send the line "unsubscribe trinity" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe trinity" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html