On 05/28/2013 10:12 PM, Toralf Förster wrote:
On 05/28/2013 09:36 PM, Daniel Borkmann wrote:
On 05/27/2013 10:21 AM, Daniel Borkmann wrote:
Just found some time to have a look into this. The issue was that the
trinity.h header must be included before some asm headers, then it works
on newer kernels.
I've attached the updated patch. Let me know if you still encounter any
problems.
So I just added this on top of your three patches sent out earlier:
diff --git a/syscalls/modify_ldt.c b/syscalls/modify_ldt.c
index a9de3a4..d601338 100644
--- a/syscalls/modify_ldt.c
+++ b/syscalls/modify_ldt.c
@@ -9,7 +9,6 @@
#define __ASSEMBLY__ 1
#include <asm/ldt.h>
-#include "trinity.h"
#include "sanitise.h"
#include "shm.h"
and get now at a stable 32bit Gentoo Linux :
CC syscalls/setreuid16.o
syscalls/modify_ldt.c: In function ‘sanitise_modify_ldt’: CC syscalls/setuid.o
syscalls/modify_ldt.c:26:3: error: implicit declaration of function ‘bdw_malloc’ [-Werror=implicit-function-declaration]
syscalls/modify_ldt.c:26:3: error: nested extern declaration of ‘bdw_malloc’ [-Werror=nested-externs]
syscalls/modify_ldt.c:26:7: error: assignment makes pointer from integer without a cast [-Werror]
cc1: all warnings being treated as errors
make: *** [syscalls/modify_ldt.o] Error 1
make: *** Waiting for unfinished jobs....
Yes, but this is wrong, obviously. Have a look into the v3 of the patch I've
sent a couple of hours ago to you and the list (was attached in the last mail):
In syscalls/modify_ldt.c, it starts with ...
diff --git a/syscalls/modify_ldt.c b/syscalls/modify_ldt.c
index 0331a3e..93271b5 100644
--- a/syscalls/modify_ldt.c
+++ b/syscalls/modify_ldt.c
@@ -1,3 +1,4 @@
+#include "trinity.h"
#include "arch.h"
#ifdef X86
@@ -8,6 +9,7 @@
#include <sys/types.h>
#define __ASSEMBLY__ 1
#include <asm/ldt.h>
+
#include "sanitise.h"
#include "shm.h"
--
To unsubscribe from this list: send the line "unsubscribe trinity" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
