>Hi Alexis,
>that is great. Would you mind creating a proper PR on tdewebdev for this?
>Please take note that we use a "shared contribution" model rather than a "fork contribution" one, for various good
>reason. You can read how to contribute using such model here:
>https://wiki.trinitydesktop.org/TDE_Gitea_Workspace#To_contribute_code_changes
>I have already made you a contributor in TGW, so you should have no problems in following the instructions and creating
>a PR. Otherwise just reach to us here.
>
>Thanks for your work, looking forward to add it to TDE!!
>
>Cheers
>Michele
>that is great. Would you mind creating a proper PR on tdewebdev for this?
>Please take note that we use a "shared contribution" model rather than a "fork contribution" one, for various good
>reason. You can read how to contribute using such model here:
>https://wiki.trinitydesktop.org/TDE_Gitea_Workspace#To_contribute_code_changes
>I have already made you a contributor in TGW, so you should have no problems in following the instructions and creating
>a PR. Otherwise just reach to us here.
>
>Thanks for your work, looking forward to add it to TDE!!
>
>Cheers
>Michele
Hello
Sorry for the wait, I did it as soon as I had time.
Thank you very much for the instructions. Also for the words of encouragement from different people.
PR created:
With this contribution is possible in Quanta to select HTML5 as DTD (Menu DTD > Change DTD > HTML5) and the new toolbars will be displayed with new icons that will insert the corresponding tag. Icons for all HMTL5 tabs are included. The templates are also included. The names used for the toolbars were already in the translation file, it is not necessary to add new translations to have it e.g. in Spanish.
Things to do if there is help from others:
- The "dtep" (whose function is to suggest attributes according to the label) need to be improved (at the moment not all new HTML5 attributes are incorporated and legacy attributes from HTML4 remain). I can do it little by little in my spare time, of course help is welcome to speed it up.
- "Source editor" mode is fully functional. "Preview" mode works (actually only the common tags between HTML4 and HTML5 work but it encompasses all the most used ones, the HTML engine I guess doesn't support HTML5). The "VPL editor" mode refuses to activate if HTML5 is selected as DTD (no crash, just not activatable). Although providing HTML5 support for the web engine and the VPL editor is a more complicated job, it should be possible in the short term to modify the VPL editor sources so that it interprets HTML5 like HTML4 without refusing to activate.
- With HTML4 as default DTD, opening a new tab with the new document (HTML4) adds the HTML4 toolbars to the HTML5 toolbars (9 toolbars in total). I'm not sure why, I think it can be easy to fix. With Menu DTD > Change DTD > HTML5, the extra HTML4 toolbars disappear.
Thanks to all the people who make it possible to have TDE in general and Quanta in particular working today.
____________________________________________________ tde-devels mailing list -- devels@xxxxxxxxxxxxxxxxxx To unsubscribe send an email to devels-leave@xxxxxxxxxxxxxxxxxx Web mail archive available at https://mail.trinitydesktop.org/mailman3/hyperkitty/list/devels@xxxxxxxxxxxxxxxxxx
