Bug 2998

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

I don't know how closely the devs watch the Bug list but I believe I've
fixed Bug 2998.

As this bug results in kdesktop/kdesktop_lock eating CPU and going
unresponsive; might I humbly request that the fix is incorporated in the
next possible/dev version.

As the code I posted on bugzilla used a crude fixed buffer, here's a
cleaned up version that uses malloc.

*** /tmp/tdebase-trinity-14.0.6~pre38/kdesktop/lock/main.cc     Thu Feb  7 15:48:21 2019
--- /usr/tmp/tdebase-trinity-14.0.6~pre38/kdesktop/lock/main.cc Sun May 20 19:41:55 2018
***************
*** 325,336 ****
  #endif
          }
  
!         char *locknameroot="kdesktop_lock_lockfile.";
!         char *lockfilename = (char*)malloc(strlen(locknameroot) + strlen(getenv("DISPLAY")) + 1);
!         strcpy(lockfilename,locknameroot);
!         strcat(lockfilename,getenv("DISPLAY"));
! 
!         TDELockFile lock(locateLocal("tmp", lockfilename));
          lock.setStaleTime(0);
          TDELockFile::LockResult lockRet = lock.lock();
          if (lockRet != TDELockFile::LockOK) {
--- 325,331 ----
  #endif
          }
  
!         TDELockFile lock(locateLocal("tmp", "kdesktop_lock_lockfile"));
          lock.setStaleTime(0);
          TDELockFile::LockResult lockRet = lock.lock();
          if (lockRet != TDELockFile::LockOK) {


-- 
 Regards,
     Russell
 --------------------------------------------------------------------
| Russell Brown          | MAIL: russell@xxxxxxx PHONE: 01780 471800 |
| Lady Lodge Systems     | WWW Work: http://www.lls.com              |
| Peterborough, England  | WWW Play: http://www.ruffle.me.uk         |
 --------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: trinity-devel-unsubscribe@xxxxxxxxxxxxxxxxxxxxxxxxxx
For additional commands, e-mail: trinity-devel-help@xxxxxxxxxxxxxxxxxxxxxxxxxx
Read list messages on the web archive: http://trinity-devel.pearsoncomputing.net/
Please remember not to top-post: http://trinity.pearsoncomputing.net/mailing_lists/#top-posting




[Index of Archives]     [Trinity Users]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [KDE]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]     [Trinity Desktop Environment]

  Powered by Linux