On 2/18/2025 11:51 PM, Christoph Hellwig wrote:
> The code that automatically creates a integrity payload and generates /
> verifies the checksums for bios that don't have submitter-provided
> integrity payload currently sits right in the middle of the block
> integrity metadata infrastruture.
nit: s/infrastruture/infrastructure.
> +static int __init blk_integrity_default_init(void)
> +{
> + /*
> + * kintegrityd won't block much but may burn a lot of CPU cycles.
> + * Make it highpri CPU intensive wq with max concurrency of 1.
> + */
> + kintegrityd_wq = alloc_workqueue("kintegrityd", WQ_MEM_RECLAIM |
> + WQ_HIGHPRI | WQ_CPU_INTENSIVE, 1);
> + if (!kintegrityd_wq)
> + panic("Failed to create kintegrityd\n");
> + return 0;
> +}
> +subsys_initcall(blk_integrity_default_init);
Now that you are using the term auto (in place of default), maybe this
should also be renamed to blk_integrity_auto_init.
Looks good otherwise.
Reviewed-by: Kanchan Joshi <joshi.k@xxxxxxxxxxx>
