Re: [PATCH] net: core: Convert inet_addr_is_any() to sockaddr_storage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Kees Cook <kees@xxxxxxxxxx>
Subject: Re: [PATCH] net: core: Convert inet_addr_is_any() to sockaddr_storage
From: Christoph Hellwig <hch@xxxxxx>
Date: Tue, 17 Dec 2024 04:56:58 +0100
Cc: Christoph Hellwig <hch@xxxxxx>, Sagi Grimberg <sagi@xxxxxxxxxxx>, Chaitanya Kulkarni <kch@xxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Mike Christie <michael.christie@xxxxxxxxxx>, Max Gurtovoy <mgurtovoy@xxxxxxxxxx>, Maurizio Lombardi <mlombard@xxxxxxxxxx>, Dmitry Bogdanov <d.bogdanov@xxxxxxxxx>, Mingzhe Zou <mingzhe.zou@xxxxxxxxxxxx>, Christophe Leroy <christophe.leroy@xxxxxxxxxx>, Simon Horman <horms@xxxxxxxxxx>, "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, target-devel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-hardening@xxxxxxxxxxxxxxx
In-reply-to: <20241217012618.work.323-kees@kernel.org>
References: <20241217012618.work.323-kees@kernel.org>
User-agent: Mutt/1.5.17 (2007-11-01)

On Mon, Dec 16, 2024 at 05:26:19PM -0800, Kees Cook wrote:
> -extern bool inet_addr_is_any(struct sockaddr *addr);
> +extern bool inet_addr_is_any(struct sockaddr_storage *addr);

You might want to drop the pointless extern here.

Otherwise this looks great:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

References:
- [PATCH] net: core: Convert inet_addr_is_any() to sockaddr_storage
  - From: Kees Cook

Prev by Date: [PATCH] net: Convert proto_ops::getname to sockaddr_storage
Next by Date: Re: [PATCH] net: Convert proto_ops::getname to sockaddr_storage
Previous by thread: [PATCH] net: core: Convert inet_addr_is_any() to sockaddr_storage
Next by thread: Re: [PATCH] net: core: Convert inet_addr_is_any() to sockaddr_storage
Index(es):
- Date
- Thread

[Index of Archives] [Linux SCSI] [Kernel Newbies] [Linux SCSI Target Infrastructure] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Device Mapper]