On 1/15/24 20:51, Li Zhijian wrote: > Per filesystems/sysfs.rst, show() should only use sysfs_emit() > or sysfs_emit_at() when formatting the value to be returned to user space. > > coccinelle complains that there are still a couple of functions that use > snprintf(). Convert them to sysfs_emit(). > >> ./drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3619:8-16: WARNING: please use sysfs_emit >> ./drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3625:8-16: WARNING: please use sysfs_emit >> ./drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3633:8-16: WARNING: please use sysfs_emit > > No functional change intended > > CC: Michael Cyr <mikecyr@xxxxxxxxxxxxx> > CC: "James E.J. Bottomley" <jejb@xxxxxxxxxxxxx> > CC: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx> > CC: linux-scsi@xxxxxxxxxxxxxxx > CC: target-devel@xxxxxxxxxxxxxxx > Signed-off-by: Li Zhijian <lizhijian@xxxxxxxxxxx> > --- Acked-by: Tyrel Datwyler <tyreld@xxxxxxxxxxxxx>