On 5/21/23 4:36 AM, Konstantin Shelekhin wrote: > On Sat, May 20, 2023 at 12:56:29PM -0500, Mike Christie wrote: >> On 5/11/23 10:40 AM, Konstantin Shelekhin wrote: >>> So, my proposal. We should give all modules similar names: >>> >>> tcm >>> tcm_iscsi >>> tcm_iser >>> tcm_qla2xxx >>> tcm_iblock >>> tcm_loop >>> tcm_cxgb >> Do you mean you will rename the actual modules, or just have each module >> have some define with a name like "tcm_$WHATEVER" that's used in the log >> message? >> >> I don't think we can change the actual name because scripts might do >> modprobe isert >> >> Unless there's a way to do some sort of automatic/magic alias then it >> would be ok. > We have MODULE_ALIAS(), so it's possible to do something similar to > drivers/md/raid5.c: Ah ok, nice. What is the target_core_fabric_ops->fabric_name going to be? I think that can't change or it will break userspace tools like rtslib/targetlci right? It would change the /sys/kernel/config/target/$fabric_name path? Do you want the module level error message to match to the fabric_name or the module name? I think the fabric_name is nicer, because it's what the users normally use to interact with the tools/kernel. Other than that, I think it's ok.
