Re: [PATCH v4 10/18] nvme: Add helper to send pr command

To: Mike Christie <michael.christie@xxxxxxxxxx>
Subject: Re: [PATCH v4 10/18] nvme: Add helper to send pr command
From: Christoph Hellwig <hch@xxxxxx>
Date: Tue, 14 Mar 2023 18:13:59 +0100
Cc: bvanassche@xxxxxxx, hch@xxxxxx, martin.petersen@xxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, james.bottomley@xxxxxxxxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxx, snitzer@xxxxxxxxxx, axboe@xxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, chaitanyak@xxxxxxxxxx, kbusch@xxxxxxxxxx, target-devel@xxxxxxxxxxxxxxx
In-reply-to: <20230224174502.321490-11-michael.christie@oracle.com>
References: <20230224174502.321490-1-michael.christie@oracle.com> <20230224174502.321490-11-michael.christie@oracle.com>
User-agent: Mutt/1.5.17 (2007-11-01)

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

althought I'd also prefer to drop the redundant else.

References:
- [PATCH v4 01/18] Use block pr_ops in LIO
  - From: Mike Christie
- [PATCH v4 10/18] nvme: Add helper to send pr command
  - From: Mike Christie