On 2/11/2023 1:50 PM, ALOK TIWARI wrote:
commit "Fixes: 12b6fcd0ea7f" introduce that change in source code.
that's reason we are using "fixes:". back-porting that change is
creating awkward manual conflict resolution.
Thanks,
Alok
On 2/11/2023 1:18 PM, Greg KH wrote:
On Fri, Feb 10, 2023 at 09:55:22AM -0800, Alok Tiwari wrote:
There is no separate blank line between
target_remove_from_tmr_list() and
transport_cmd_check_stop_to_fabric
As per coding-style, it is require to separate functions with one
blank line.
Fixes: 12b6fcd0ea7f ("scsi: target: core: Remove from tmr_list
during LUN unlink")
Signed-off-by: Alok Tiwari <alok.a.tiwari@xxxxxxxxxx>
---
drivers/target/target_core_transport.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/target/target_core_transport.c
b/drivers/target/target_core_transport.c
index 5926316252eb..f1cdf78fc5ef 100644
--- a/drivers/target/target_core_transport.c
+++ b/drivers/target/target_core_transport.c
@@ -691,6 +691,7 @@ static void target_remove_from_tmr_list(struct
se_cmd *cmd)
spin_unlock_irqrestore(&dev->se_tmr_lock, flags);
}
}
+
/*
* This function is called by the target core after the target
core has
* finished processing a SCSI command or SCSI TMF. Both the
regular command
--
2.39.1
Why is a coding style change tagged with a "fixes:" line and cc: stable?
thanks,
greg k-h
I will send new version to remove -> "fixes:" line and cc: stable
Thanks,
Alok
