Re: [PATCH] scsi: target: tcmu: Avoid holding XArray lock when calling lock_page

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Bodo Stroesser <bostroesser@xxxxxxxxx>
Subject: Re: [PATCH] scsi: target: tcmu: Avoid holding XArray lock when calling lock_page
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Tue, 17 May 2022 21:52:00 -0400
Cc: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, target-devel@xxxxxxxxxxxxxxx, Xiaoguang Wang <xiaoguang.wang@xxxxxxxxxxxxxxxxx>, Dan Carpenter <dan.carpenter@xxxxxxxxxx>
In-reply-to: <20220517192913.21405-1-bostroesser@gmail.com> (Bodo Stroesser's message of "Tue, 17 May 2022 21:29:13 +0200")
Organization: Oracle Corporation
References: <20220517192913.21405-1-bostroesser@gmail.com>

Bodo,

> In tcmu_blocks_release, lock_page() is called to prevent a race
> causing possible data corruption. Since lock_page() might sleep,
> calling it while holding XArray lock is a bug.

Applied to 5.19/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

References:
- [PATCH] scsi: target: tcmu: Avoid holding XArray lock when calling lock_page
  - From: Bodo Stroesser

Prev by Date: Re: [PATCH v2] scsi: target: fixup incorrect use of 'cpumask_t'
Next by Date: Re: [PATCH v2] scsi: target: fixup incorrect use of 'cpumask_t'
Previous by thread: [PATCH] scsi: target: tcmu: Avoid holding XArray lock when calling lock_page
Next by thread: Re: [PATCH] scsi: target: tcmu: Avoid holding XArray lock when calling lock_page
Index(es):
- Date
- Thread

[Index of Archives] [Linux SCSI] [Kernel Newbies] [Linux SCSI Target Infrastructure] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Device Mapper]

Powered by Linux