Hi Dmitry, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on v5.15-rc6] [cannot apply to mkp-scsi/for-next next-20211018] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Dmitry-Bogdanov/target-iscsi-control-authentication-per-ACL/20211019-023356 base: 519d81956ee277b4419c723adfb154603c2565ba config: arm-randconfig-r015-20211019 (attached as .config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project d245f2e8597bfb52c34810a328d42b990e4af1a4) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm cross compiling tool for clang build # apt-get install binutils-arm-linux-gnueabi # https://github.com/0day-ci/linux/commit/86c706d4db6af27167e04b97242cc82dfbfc2212 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Dmitry-Bogdanov/target-iscsi-control-authentication-per-ACL/20211019-023356 git checkout 86c706d4db6af27167e04b97242cc82dfbfc2212 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): >> drivers/target/iscsi/iscsi_target_nego.c:814:6: warning: no previous prototype for function 'iscsi_conn_auth_required' [-Wmissing-prototypes] bool iscsi_conn_auth_required(struct iscsi_conn *conn) ^ drivers/target/iscsi/iscsi_target_nego.c:814:1: note: declare 'static' if the function is not intended to be used outside of this translation unit bool iscsi_conn_auth_required(struct iscsi_conn *conn) ^ static 1 warning generated. vim +/iscsi_conn_auth_required +814 drivers/target/iscsi/iscsi_target_nego.c 813 > 814 bool iscsi_conn_auth_required(struct iscsi_conn *conn) 815 { 816 struct se_node_acl *se_nacl; 817 818 if (conn->sess->sess_ops->SessionType) { 819 /* 820 * For SessionType=Discovery 821 */ 822 return conn->tpg->tpg_attrib.authentication; 823 } 824 /* 825 * For SessionType=Normal 826 */ 827 se_nacl = conn->sess->se_sess->se_node_acl; 828 if (!se_nacl) { 829 pr_debug("Unknown ACL %s is trying to connect\n", 830 se_nacl->initiatorname); 831 return true; 832 } 833 834 if (se_nacl->dynamic_node_acl) { 835 pr_debug("Dynamic ACL %s is trying to connect\n", 836 se_nacl->initiatorname); 837 return conn->tpg->tpg_attrib.authentication; 838 } 839 840 pr_debug("Known ACL %s is trying to connect\n", 841 se_nacl->initiatorname); 842 return conn->tpg->tpg_attrib.authentication; 843 } 844 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip