RE: [PATCH v3] target: core: remove from tmr_list at lun unlink

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mike,

> Yeah, I think it's not needed. It came in with:
>
> commit 2c9fa49e100f962af988f1c0529231bf14905cda
> Author: Bart Van Assche <bvanassche@xxxxxxx>
> Date:   Tue Nov 27 15:52:03 2018 -0800
>
>     scsi: target/core: Make ABORT and LUN RESET handling synchronous
> gree. It looks like it was added in:
>
> and in that patch I can't see it ever happening. We have 2 ways to submit
> an abort tmr:
>
> 1. target_submit_tmr - Calls transport_lookup_tmr_lun then
> transport_generic_handle_tmr.
>
> 2. iscsit_handle_task_mgt_cmd - Will call transport_lookup_tmr_lun
> for every tmr except the iscsi specific TASK REASSIGN. TASK REASSING
> is not passed to transport_generic_handle_tmr.
>
> I don't see any places where tmr_dev is NULL after transport_lookup_tmr_lun
> has set it and added it to the list.
>
> So I think you can just kill it.

Ok, then in the next revision of the patch I will just remove that transport_lookup_tmr_lun with WARN_ON.

BR,
 Dmitry




[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux