Re: [PATCH 1/1] scsi: target: core: Fix sense key for invalid XCOPY request

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Sergey Samoylenko <s.samoylenko@xxxxxxxxx>, martin.petersen@xxxxxxxxxx, michael.christie@xxxxxxxxxx, target-devel@xxxxxxxxxxxxxxx
Subject: Re: [PATCH 1/1] scsi: target: core: Fix sense key for invalid XCOPY request
From: Bart Van Assche <bvanassche@xxxxxxx>
Date: Thu, 24 Jun 2021 08:57:47 -0700
Cc: linux-scsi@xxxxxxxxxxxxxxx, linux@xxxxxxxxx, Roman Bolshakov <r.bolshakov@xxxxxxxxx>, Konstantin Shelekhin <k.shelekhin@xxxxxxxxx>
In-reply-to: <20210624111926.63176-2-s.samoylenko@yadro.com>
References: <20210624111926.63176-1-s.samoylenko@yadro.com> <20210624111926.63176-2-s.samoylenko@yadro.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 6/24/21 4:19 AM, Sergey Samoylenko wrote:
> +	pr_warn_ratelimited("target_xcopy_do_work: rc: %d, sense: %u,"
> +		" XCOPY operation failed\n", rc, sense_rc);

Please do not split format strings across multiple lines. Checkpatch
should have complained about this.

Thanks,

Bart.

Follow-Ups:
- RE: [PATCH 1/1] scsi: target: core: Fix sense key for invalid XCOPY request
  - From: Sergey Samoylenko

References:
- [PATCH 0/1] scsi: target: core: Fix sense key for invalid XCOPY request
  - From: Sergey Samoylenko
- [PATCH 1/1] scsi: target: core: Fix sense key for invalid XCOPY request
  - From: Sergey Samoylenko

Prev by Date: Re: [PATCH 1/1] scsi: target: core: Fix sense key for invalid XCOPY request
Next by Date: RE: [PATCH 1/1] scsi: target: core: Fix sense key for invalid XCOPY request
Previous by thread: Re: [PATCH 1/1] scsi: target: core: Fix sense key for invalid XCOPY request
Next by thread: RE: [PATCH 1/1] scsi: target: core: Fix sense key for invalid XCOPY request
Index(es):
- Date
- Thread

[Index of Archives] [Linux SCSI] [Kernel Newbies] [Linux SCSI Target Infrastructure] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Device Mapper]