On Mon, May 24, 2021 at 09:35:27AM +0200, Christoph Hellwig wrote: > > using size_t makes it clear that these are byte counts, not (eg) sector > > counts. i do think it's good to make the return value unsigned so we > > don't have people expecting a negative errno on failure. > > I think the right type is bool. We always return either 0 or the full > length we tried to add. Instead of optimizing for a partial add (which > only makes sense for bio_add_hw_page anyway), I'd rather make the > interface as simple as possible. Sounds good to me.
