On 5/17/21 5:39 AM, Maurizio Lombardi wrote:
> static bool
> __transport_wait_for_tasks(struct se_cmd *cmd, bool fabric_stop,
> bool *aborted, bool *tas, unsigned long *flags)
> __releases(&cmd->t_state_lock)
> __acquires(&cmd->t_state_lock)
> {
>
> assert_spin_locked(&cmd->t_state_lock);
> WARN_ON_ONCE(!irqs_disabled()); <----------
>
> I guess this is due to the fact that on realtime kernels spin_lock_irq*() do not
> disable the interrupts, so the call to irqs_disabled() returns false.
It's probably fine to leave out that WARN_ON_ONCE() call. And the
assert_spin_locked() probably should be changed into a
lockdep_assert_held() call.
Thanks,
Bart.
