On 5/6/21 4:34 AM, Leon Romanovsky wrote:
> On Thu, May 06, 2021 at 06:15:05PM +0800, Yang Li wrote:
>> Variable 'ret' is set to -ENOMEM but this value is never read as it is
>> overwritten with a new value later on, hence it is a redundant
>> assignment and can be removed
>>
>> In 'commit b79fafac70fc ("target: make queue_tm_rsp() return void")'
>> srpt_queue_response() has been changed to return void, so after "goto
>> out", there is no need to return ret.
>>
>> Clean up the following clang-analyzer warning:
>>
>> drivers/infiniband/ulp/srpt/ib_srpt.c:2860:3: warning: Value stored to
>> 'ret' is never read [clang-analyzer-deadcode.DeadStores]
>>
>> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
>> Signed-off-by: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>
>> ---
>> drivers/infiniband/ulp/srpt/ib_srpt.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>
> Fixes: b99f8e4d7bcd ("IB/srpt: convert to the generic RDMA READ/WRITE API")
>
> Thanks,
> Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxx>
Reverting commit b99f8e4d7bcd and handling queue_*_rsp() errors in the
LIO core probably would be a better approach. Anyway:
Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>
