Re: [PATCH v3 1/7] target: core: add common tpg/enable attribute

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dmitry,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on v5.12-rc6]
[also build test ERROR on next-20210409]
[cannot apply to mkp-scsi/for-next scsi/for-next target/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Dmitry-Bogdanov/target-make-tpg-enable-attribute/20210409-204948
base:    e49d033bddf5b565044e2abe4241353959bc9120
config: x86_64-rhel-8.3-kselftests (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/05e500ae0f710beb2f952c2e99ab5d4fd2fce126
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Dmitry-Bogdanov/target-make-tpg-enable-attribute/20210409-204948
        git checkout 05e500ae0f710beb2f952c2e99ab5d4fd2fce126
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   drivers/target/target_core_fabric_configfs.c: In function 'target_fabric_setup_cits':
>> drivers/target/target_core_fabric_configfs.c:1047:2: error: 'ret' undeclared (first use in this function); did you mean 'net'?
    1047 |  ret = target_fabric_setup_tpg_base_cit(tf);
         |  ^~~
         |  net
   drivers/target/target_core_fabric_configfs.c:1047:2: note: each undeclared identifier is reported only once for each function it appears in


vim +1047 drivers/target/target_core_fabric_configfs.c

  1039	
  1040	int target_fabric_setup_cits(struct target_fabric_configfs *tf)
  1041	{
  1042		target_fabric_setup_discovery_cit(tf);
  1043		target_fabric_setup_wwn_cit(tf);
  1044		target_fabric_setup_wwn_fabric_stats_cit(tf);
  1045		target_fabric_setup_tpg_cit(tf);
  1046	
> 1047		ret = target_fabric_setup_tpg_base_cit(tf);

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux