RE: [PATCH v2 1/7] target: core: add common tpg/enable attribute

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mike,

Thank you for the comments.

> > +	if (tf->tf_ops->fabric_enable_tpg)
> > +		for (i = 0; core_tpg_base_enable_attrs[i]; i++)
> > +			attrs[i] = core_tpg_base_enable_attrs[i];
> > +	if (tf->tf_ops->tfc_tpg_base_attrs)
> > +		for (k = 0; tf->tf_ops->tfc_tpg_base_attrs[k]; k++, i++)

> If fabric_enable_tpg is not set then I think i is the value from above when we did the tfc_tpg_base_attrs loop to calculate the total len needed for the kzalloc.
Yes, you are right, will fix it.

> > +			attrs[i] = tf->tf_ops->tfc_tpg_base_attrs[k];
> > +	attrs[i] = NULL;

> If fabric_enable_tpg and tfc_tpg_base_attrs attrs is not set then i is not initialized.
Yes, you are right, will fix it.

> I'm guessing you guys do more testing with tcm_qla. Maybe also do a quick target creation test with iscsi and loop to hit some of the different combos.
Shame on me. I did tests for v1 and believed that v2 also works because of trivial changes. I will test each version before submission in the future.

BR,
 Dmitry




[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux