On Fri, Feb 12, 2021 at 04:17:34PM -0600, Mike Christie wrote: > Hey Christoph, I think I misinterpreted your review comment about adding a > warning here. I thought you wanted it so we could detect there was a problem > early on. We can't do that, but I can do: > > + rc = target_init_cmd(se_cmd, se_sess, sense, unpacked_lun, data_length, > + task_attr, data_dir, flags); > + WARN(rc, "Invalid target_submit_cmd use. Driver must not use target_stop_session or call target_init_cmd directly.\n"); > > and we can at least warn someone at some point. Yes, that is what I meant.