On 2/4/21 5:25 PM, Chaitanya Kulkarni wrote: >> * queue_cmd_ring - queue cmd to ring or internally >> * @tcmu_cmd: cmd to queue >> @@ -1086,8 +1108,8 @@ static int queue_cmd_ring(struct tcmu_cmd *tcmu_cmd, sense_reason_t *scsi_err) >> >> list_add_tail(&tcmu_cmd->queue_entry, &udev->inflight_queue); >> >> - /* TODO: only if FLUSH and FUA? */ >> - uio_event_notify(&udev->uio_info); >> + if (!test_bit(TCM_DEV_BIT_PLUGGED, &udev->flags)) >> + uio_event_notify(&udev->uio_info); >> > Do we need to keep the TODO ? I think it's not helpful. The reason for the TODO was to avoid calling uio_event_notify for every command. I think we had thought we could just key of a FLUSH but then later figured out we might not always get one so that wouldn't work. The comment should have been removed or if we like to keep TODOs like that in code it should have been updated to better reflect what the issue was and the idea to fix it.
