On 1/20/21 7:01 PM, Julian Calaby wrote: > Hi Chaitanya, > > On Tue, Jan 19, 2021 at 5:01 PM Chaitanya Kulkarni > <chaitanya.kulkarni@xxxxxxx> wrote: >> Hi, >> >> This is a *compile only RFC* which adds a generic helper to initialize >> the various fields of the bio that is repeated all the places in >> file-systems, block layer, and drivers. >> >> The new helper allows callers to initialize various members such as >> bdev, sector, private, end io callback, io priority, and write hints. >> >> The objective of this RFC is to only start a discussion, this it not >> completely tested at all. >> Following diff shows code level benefits of this helper :- >> 38 files changed, 124 insertions(+), 236 deletions(-) > On a more abstract note, I don't think this diffstat is actually > illustrating the benefits of this as much as you think it is. > > Yeah, we've reduced the code by 112 lines, but that's barely half the > curn here. It looks, from the diffstat, that you've effectively > reduced 2 lines into 1. That isn't much of a saving. > > Thanks, The diff stat is not the only measure since every component fs/driver has a different style and nested call it just to show the effect. Thanks for your comment, we have decided to go with the bio_new approach.
