On 10/26/20 2:06 PM, David Disseldorp wrote:
This patchset adds missing functionality to return the offset of non-matching read/compare data in the sense INFORMATION field on COMPARE AND WRITE miscompare. The functionality can be tested using the libiscsi CompareAndWrite.MiscompareSense test proposed via: https://urldefense.com/v3/__https://github.com/sahlberg/libiscsi/pull/344__;!!GqivPVa7Brio!LJ-un7MDdHXhZgIK1qgvDgza2El16FK-T_4oDi6VqM0CzetAV9pGHDvLDrZUkITTHxhO$ Changes since v1: - drop unnecessary WARN_ON() - fix two checkpatch warnings - drop single-use nlbas variable - avoid compare_len recalculation Cheers, David drivers/target/target_core_sbc.c | 137 +++++++++++++++---------- drivers/target/target_core_transport.c | 33 +++--- include/target/target_core_base.h | 2 +- lib/scatterlist.c | 2 +- 4 files changed, 102 insertions(+), 72 deletions(-)
Reviewed-by: Mike Christie <michael.christie@xxxxxxxxxx>