On 10/16/20 2:58 PM, Bodo Stroesser wrote: > + > +static inline void tcmu_copy_data(struct tcmu_dev *udev, > + struct tcmu_cmd *tcmu_cmd, uint32_t direction, > + struct scatterlist *sg, unsigned int sg_nents, > + struct iovec **iov, > + int data_len) It's a nice cleanup. I only have a small nit. This line should have been merged with the one above it.