> On Jun 19, 2020, at 12:38 PM, Bodo Stroesser <bstroesser@xxxxxxxxxxxxxx> wrote:
>
> Since
> commit 61fb24822166 ("scsi: target: tcmu: Userspace must not complete
> queued commands")
> tcmu_cmd bit TCMU_CMD_BIT_INFLIGHT is set but never checked.
> So we can remove it safely.
>
> Signed-off-by: Bodo Stroesser <bstroesser@xxxxxxxxxxxxxx>
> ---
> drivers/target/target_core_user.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c
> index 560bfec933bc..b38da27e033f 100644
> --- a/drivers/target/target_core_user.c
> +++ b/drivers/target/target_core_user.c
> @@ -181,7 +181,6 @@ struct tcmu_cmd {
> unsigned long deadline;
>
> #define TCMU_CMD_BIT_EXPIRED 0
> -#define TCMU_CMD_BIT_INFLIGHT 1
> unsigned long flags;
> };
> /*
> @@ -1078,7 +1077,6 @@ static int queue_cmd_ring(struct tcmu_cmd *tcmu_cmd, sense_reason_t *scsi_err)
> tcmu_flush_dcache_range(mb, sizeof(*mb));
>
> list_add_tail(&tcmu_cmd->queue_entry, &udev->inflight_queue);
> - set_bit(TCMU_CMD_BIT_INFLIGHT, &tcmu_cmd->flags);
>
> /* TODO: only if FLUSH and FUA? */
> uio_event_notify(&udev->uio_info);
Acked-by: Mike Christie <michael.crhsitie@xxxxxxxxxx>
