Re: [PATCH 2/3] target/core: Fix a use-after-free in the TMF handling code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 13, 2019 at 09:05:15AM -0800, Bart Van Assche wrote:
> On 11/13/19 4:02 AM, Roman Bolshakov wrote:
> > As far as I understand the change prevents backstore directory removal
> > from TCM configfs when a TMF is processed and targetcli would start
> > to fail sporadically as it tries to delete configfs directories only once:
> >    https://github.com/open-iscsi/rtslib-fb/blob/master/rtslib/node.py#L228
> > 
> > Should we hold se_device device without preventing removal of backstore?
> 
> How about using config_item_get()/config_item_put() instead of
> target_depend_item()/target_undepend_item()?
> 
> Thanks,
> 
> Bart.

Yes,
config_item_get()/config_item_put() or
config_group_get()/config_group_put() seem to be better solutions.

Thanks,
Roman



[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux