On 10/10/19 11:57 AM, Bodo Stroesser wrote:
Hmm. You are right. Ideally only SCSI-2 compliant initiators should use the LUN field and they should run parallel SCSI only. OTOH, like Mike already said, we can't know whether there is any SW, FW, BIOS, ... out there, that still sends such old style CDBs. For example: probably SW could send such CDBs by simply using SCSI generic device on top of a modern initiator. (I hope that's true, I didn't test ...) That means, old code can produce old SCSI CDBs even when running on top of modern HW. Do we want to take the risk of breaking such "old stuff"?
Is blindly filtering out the LUN number correct? All initiator code that I found and that touches the highest three bits of that byte sets the LUN number in that byte. From the SCSI error handler:
if (sdev->scsi_level <= SCSI_2 && sdev->scsi_level != SCSI_UNKNOWN) scmd->cmnd[1] = (scmd->cmnd[1] & 0x1f)|(sdev->lun << 5 & 0xe0); Bart.
