Re: [PATCH] target/core: Make it safe to pass NULL as third argument to compare_and_write_callback()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Bart Van Assche <bvanassche@xxxxxxx>
Subject: Re: [PATCH] target/core: Make it safe to pass NULL as third argument to compare_and_write_callback()
From: David Disseldorp <ddiss@xxxxxxx>
Date: Mon, 5 Nov 2018 20:09:10 +0100
Cc: "Martin K . Petersen" <martin.petersen@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, target-devel@xxxxxxxxxxxxxxx, Nicholas Bellinger <nab@xxxxxxxxxxxxxxx>, Mike Christie <mchristi@xxxxxxxxxx>, Hannes Reinecke <hare@xxxxxxx>
In-reply-to: <20181105185523.725d91d6@suse.de>
References: <20181105172317.248955-1-bvanassche@acm.org> <20181105185523.725d91d6@suse.de>

On Mon, 5 Nov 2018 18:55:23 +0100, David Disseldorp wrote:

> IIUC, this still leaves compare_and_write_post() with a potential NULL
> post_ret deref.

Actually, I missed that aa73237dcb2d also added the if(success) check
there. Either way, I find your latter fix easier to follow.

Cheers, David

References:
- [PATCH] target/core: Make it safe to pass NULL as third argument to compare_and_write_callback()
  - From: Bart Van Assche
- Re: [PATCH] target/core: Make it safe to pass NULL as third argument to compare_and_write_callback()
  - From: David Disseldorp

Prev by Date: [PATCH] target/core: Avoid that a kernel oops can be triggered when an XCOPY command fails
Next by Date: Re: [PATCH] target/core: Avoid that a kernel oops can be triggered when an XCOPY command fails
Previous by thread: Re: [PATCH] target/core: Make it safe to pass NULL as third argument to compare_and_write_callback()
Next by thread: Re: [PATCH] target/core: Make it safe to pass NULL as third argument to compare_and_write_callback()
Index(es):
- Date
- Thread

[Index of Archives] [Linux SCSI] [Kernel Newbies] [Linux SCSI Target Infrastructure] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Device Mapper]