On Sat, Oct 20, 2018 at 09:45:16AM -0700, Roland Dreier wrote: > From: Roland Dreier <roland@xxxxxxxxxxxxxxx> > > If, for example, I don't enable CONFIG_TCM_PSCSI, then every time I load > the target subsystem, I get an annoying > > Unable to load target_core_pscsi > > kernel log message. Instead let's only request_module() on things if that > code is enabled. > > Signed-off-by: Roland Dreier <roland@xxxxxxxxxxxxxxx> I guess this ok. I aways thought these request_module calls were a horrible idea to start with, but just removing them now migh break existing setups.. Reviewed-by: Christoph Hellwig <hch@xxxxxx>